Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing JDK20 with JDK21 in pipelines #765

Merged

Conversation

adamfarley
Copy link
Contributor

There will be no more JDK20 releases, and JDK21 is next to be released, so this PR does a swap.

Also includes some improvements to generateBuildMatrix.sh that makes the code and the output more readable.

There will be no more JDK20 releases, and JDK21 is next to be
released, so this PR does a swap.

Also includes some improvements to generateBuildMatrix.sh that
makes the code and the output more readable.

Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley self-assigned this Aug 7, 2023
@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts documentation testing generation Issues that provide enhancements or fixes to the job generators ghActions jenkins-pipeline labels Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@adamfarley
Copy link
Contributor Author

I performed a more in-depth replacement than usual as JDK21 is an LTS, and therefore more likely to be around longer.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks Adam

@andrew-m-leonard
Copy link
Contributor

run tests quick

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@andrew-m-leonard andrew-m-leonard merged commit 9cbb52c into adoptium:master Aug 8, 2023
7 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
There will be no more JDK20 releases, and JDK21 is next to be
released, so this PR does a swap.

Also includes some improvements to generateBuildMatrix.sh that
makes the code and the output more readable.

Signed-off-by: Adam Farley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts documentation generation Issues that provide enhancements or fixes to the job generators ghActions jenkins-pipeline testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants