Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure evaluation pipeline config load resets groovy binding before the load #790

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Aug 22, 2023

Ensure evaluation pipeline config load resets groovy binding before the load, so any old values are not picked up.
Same fix as cedc501
Also fixed typo in jdk17u schedule.

Fixes: #789

@andrew-m-leonard andrew-m-leonard self-assigned this Aug 22, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline labels Aug 22, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about the way these pipelines work to give a full code review based on the description, but this superficially sounds reasonable and if you believe it fixes the pipeline triggers then it shouldn't make things any worse, so I'm approving :-)

@andrew-m-leonard andrew-m-leonard merged commit 1ded474 into adoptium:master Aug 24, 2023
7 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
…he load (adoptium#790)

* Ensure evaluation pipeline config loaded correctly

Signed-off-by: Andrew Leonard <[email protected]>

* Ensure evaluation pipeline config loaded correctly

Signed-off-by: Andrew Leonard <[email protected]>

* Ensure evaluation pipeline config loaded correctly

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk21 and 17 evaluation schedules not being set correctly
3 participants