Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce_compare needs longer than 2 hour time limit to do a Windows build #943

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

The tools/reproduce_comparison/Jenkinsfile job was only giving 2hours to do a Windows build and archive, needs longer than that, it was aborting at 2hours:
https://ci.adoptium.net/view/ReproducibleBuild/job/jdk21u-windows-x64-temurin_reproduce_compare/36/

Test run with 3hour timeout: https://ci.adoptium.net/view/ReproducibleBuild/job/jdk21u-windows-x64-temurin_reproduce_compare/38

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added windows x64 Issues that affect or relate to the x64/x32 LINUX OS labels Feb 26, 2024
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo merged commit e8da763 into adoptium:master Feb 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants