Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Add alpine 3.14 container for docker host #2277

Merged
merged 3 commits into from
Sep 30, 2021
Merged

unixPB: Add alpine 3.14 container for docker host #2277

merged 3 commits into from
Sep 30, 2021

Conversation

jeffalder
Copy link
Contributor

@jeffalder jeffalder commented Jul 17, 2021

Fixes #2064

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • n/a for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@jeffalder jeffalder marked this pull request as ready for review July 17, 2021 21:23
@github-actions github-actions bot added docker and removed docker labels Jul 17, 2021
@jeffalder
Copy link
Contributor Author

Added 07992ba to align with #2280 .

@jeffalder jeffalder closed this Jul 17, 2021
@jeffalder jeffalder reopened this Jul 17, 2021
@github-actions github-actions bot added docker and removed docker labels Jul 17, 2021
@jeffalder jeffalder changed the title Add alpine 3.14 container for docker host unixPB: Add alpine 3.14 container for docker host Jul 18, 2021
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna karianna requested a review from sxa July 19, 2021 10:53
@github-actions github-actions bot added docker and removed docker labels Jul 22, 2021
@jeffalder
Copy link
Contributor Author

rebased to re-sign commits and make email address public.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I get an error with the --check option on sha512sum with this. Did you not see the same problem @jeffalder?

Step 7/20 : RUN echo "0fd2771dca2b8b014a4cb3246715b32e20ad5d26754186d82eee781507a183d5e63064890b95eb27c091c93c1209528a0b18a6d7e6901899319492a7610e74ad  /tmp/ant-contrib.tgz" >> /tmp/ant.sha512
 ---> Running in 17bb185fe06f
Removing intermediate container 17bb185fe06f
 ---> 81b1149766de
Step 8/20 : RUN sha512sum --check --strict /tmp/ant.sha512
 ---> Running in c23d8d44ac29
sha512sum: unrecognized option: check
BusyBox v1.33.1 () multi-call binary.

Usage: sha512sum [-c[sw]] [FILE]...

Print or check SHA512 checksums

	-c	Check sums against list in FILEs
	-s	Don't output anything, status code shows success
	-w	Warn about improperly formatted checksum lines
The command '/bin/sh -c sha512sum --check --strict /tmp/ant.sha512' returned a non-zero code: 1

@github-actions github-actions bot added docker and removed docker labels Sep 7, 2021
@jeffalder
Copy link
Contributor Author

@sxa sorry about that, fixed the command in 096b3bc.

@jeffalder
Copy link
Contributor Author

I would have tested this, but IIRC I was unable to get VirtualBox running without access to secrets, despite several hack attempts.

@sxa
Copy link
Member

sxa commented Sep 22, 2021

I would have tested this, but IIRC I was unable to get VirtualBox running without access to secrets, despite several hack attempts.

Hmm if you can ping me on slack/twitter (or we can just start another issue in this repo) I'd be intererestedin hearing about this in more detail - I want these to be usable by everyone so even if just for documentation purposes I'd be keen to hear about the details of the failure you encountered :-)
At the very least, if you skip the adoptopenjdk and jenkins tags (as mentioned in the ansible quickstart guide) that is generaly enough to let anyone run through them

@sxa
Copy link
Member

sxa commented Sep 22, 2021

@Haroon-Khel Can you get this deployed on our machines. We should probably look at getting rid of some of the earlier versions and use 3.14 in preference now

@Haroon-Khel
Copy link
Contributor

@sxa Got it deployed on dockerhost-equinix-ubuntu2004-x64-2. Its up and running in jenkins at https://ci.adoptopenjdk.net/computer/test-docker-alpine314-x64-1/

alpine 3.11 and 3.12 are running on dockerhost-equinix-ubuntu2004-x64-1. If you have no objection, I'll stop those docker containers

@Haroon-Khel
Copy link
Contributor

Also, does fakeroot need to be added to the apk install list?

@jeffalder
Copy link
Contributor Author

I've lost interest in continuing this, I'm going to close it.

@jeffalder jeffalder closed this Sep 28, 2021
@sxa
Copy link
Member

sxa commented Sep 28, 2021

@sxa Got it deployed on dockerhost-equinix-ubuntu2004-x64-2. Its up and running in jenkins at https://ci.adoptopenjdk.net/computer/test-docker-alpine314-x64-1/

alpine 3.11 and 3.12 are running on dockerhost-equinix-ubuntu2004-x64-1. If you have no objection, I'll stop those docker containers

Let's keep them going for now, although if we start to hit capacity problems we can shut them down again.

Unsure on which systems we require fakeroot on, although on the basis that no-one has objected to it not being on the existing Alpine boxes we're probably ok, but I'll let @sophia-guo comment on whether it's been viisble as a problem there so far since she put in the request for fakeroot on the main Linux machines.

@jeffalder Your work on this PR looks good and is complete now and since the new container has been deployed by @Haroon-Khel using your dockerfile we should definiteiy merge this as it's now in production :-)

@sxa sxa reopened this Sep 28, 2021
@github-actions github-actions bot added docker and removed docker labels Sep 28, 2021
@sxa
Copy link
Member

sxa commented Sep 30, 2021

In the absence of a reply from @sophia-guo I'm going to assume this is OK - we can resolve later if required.

@sxa sxa merged commit 20dad27 into adoptium:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add static Docker container with Alpine Linux 3.14 for testing
4 participants