UnixPB: Add tags to tasks in Common role #3580
Conversation
|
I've started running the VPC checks (link in description) |
|
@aswinkr77 Seems to be a number of CI failures, not sure if related... |
|
@karianna it's related I think. The task |
|
I think I'll remove all the unnecessary tags and add only the necessary tags we need in the main.yml file. |
|
This solution is not viable at the moment. I'll add the missing tags to the tasks and stick with skipping tags instead of running the tags. |
aswinkr77
force-pushed
the
Common-tags
branch
2 times, most recently
from
22df1a8
to
72a7f79
Compare
aswinkr77
changed the title
aswinkr77
force-pushed
the
Common-tags
branch
2 times, most recently
from
22df1a8
to
6c15441
Compare
aswinkr77
changed the title
|
@sxa I've changed the approach. Since the VPC checks were failing - related to the newly(previously) added tags in the main.yml file. Now I've removed it, and added tags to almost all tasks in all sub folder tasks in Common role. So these tags can be used to skip unnecessary tasks. |
|
@sxa any updates in this? |
Apologies for not being too responsive on this. What's making me nervous is whether it will definitely work in both situations i.e. will the playbooks run to completion with As an example I've just tried a quick test on a few scenarios using --skip-tags build_tools:
With A coupler of other notes:
|
|
Have rebased via GH UI |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
|
@sxa the example shown here is using a customized play level ibm_main.yml file, somehow the main.yml is running all the roles, instead of running only the roles/tasks associated with the particular tags specified in
the The In the above example, the
maybe the packages needed for |
|
@sxa anything on this? |
Our team has been tied up with release work since last Tuesday so have not had any time to dedicate to other work since then.
Understood. It's not easy to make it work both ways :-) We'll need to thing about whether we can make that clear to people running the playbooks as it superficially feels natural that you could run with
We'll need to understand that and resolve it IMHO. It would be problematic if the playbooks weren't able to work unless those were preinstalled (maybe they are on your internal fyre systems) |
|
@sxa I'll summarise the changes here:
the
cause the
ref: #3580 (comment)
The only change I made was to add
The failures are unrelated to changes I made. The failures are all related to the existing PB I believe. |
OK understood - I do feel we should probably try to resolve the underlying issues though. Moving and adding the existing tags doesn't seem to serve much purpose when they don't currently work. Is there a use case which would be solved by this PR given that it's already broken when skipping these days? It's difficult to approve a change that cannot be easily tested. |
|
/thaw |
github-actions
bot
dismissed
their stale review
Pull Request unblocked - code freeze is over.
They do work. See here: #3580 (comment)
The use case is basically to skip all related tasks. For example, we sometimes(IBM) won't be needing tasks related to |
Added tags to sub folder tasks in Common role, such that these tags can be used to run/skip the respective tasks.
Checklist
Running https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1875/<<< Failed for a variety of reasons so I'm trying again at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1877/ <<< Also failed for various reasons - https://ci.adoptium.net/job/VagrantPlaybookCheck/1880/. New run 1/July https://ci.adoptium.net/job/VagrantPlaybookCheck/1898/