Fix regex for checking SSC output - include all possible Java versions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mesbah <[email protected]>
|
The fix is to obtain the actual java version number of the JVM on which the test is running and use that as part of the regex expression string in the test. Tested this PR with Java 8 : https://hyc-runtimes-jenkins.swg-devops.com/view/Test_system/job/Grinder/17/consoleFull Tested with Java 10 (fails at a later state, but passes step 5 - which is what is related to this PR): https://hyc-runtimes-jenkins.swg-devops.com/view/Test_system/job/Grinder/19/console |
|
@llxia - Could you please review and merge this PR? |
|
Do we have issue open for step 6 failure? |
|
Created new issue to handle the failure in step 6 : #33 |
llxia
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves eclipse-openj9/openj9#2315
Signed-off-by: Mesbah [email protected]