Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass in openj9 systemtest repo and branch #94

Open
sophia-guo opened this issue Jun 30, 2021 · 10 comments · May be fixed by #181
Open

Add option to pass in openj9 systemtest repo and branch #94

sophia-guo opened this issue Jun 30, 2021 · 10 comments · May be fixed by #181
Labels
good first issue Good for newcomers

Comments

@sophia-guo
Copy link
Contributor

Currently we are using the default eclipse-openj9/openj9-systemtest to run against openj9 java implementation. It would be nice to add eclipse-openj9/openj9-systemtest repo and branch as options. So run-aqa action can also be used as the part of eclipse-openj9/openj9-systemtest developer's PR tests.

@sophia-guo sophia-guo added the good first issue Good for newcomers label Jun 30, 2021
@somya-15
Copy link
Contributor

somya-15 commented Oct 1, 2021

Can I (Somya-15) and Nandini(nandini-4120) be assigned this issue. We are willing to collaborate on this issue.

@smlambert
Copy link
Contributor

I can assign you if you make a comment in the issue, @Nandini-4120

@smlambert
Copy link
Contributor

Note the solution to this will be similar to PR #102 and PR #103

@Nandini-4120
Copy link

Can I Nandini(nandini-4120) be assigned this issue? Somya and me are willing to collaborate on this issue.

Nandini-4120 added a commit to Nandini-4120/run-aqa that referenced this issue Oct 10, 2021
@somya-15
Copy link
Contributor

somya-15 commented Oct 10, 2021

Hi, I(somya-15) and Nandini(Nandini-4120) collaborated on this single issue. Kindly consider us as contributors for the PR.
Should both of us fill the ECA agreement?

@smlambert
Copy link
Contributor

Yes, both need the ECA agreement signed, and the PR should use the "Co-authored-by" keyword so that both authors get credited for the change.

(related doc: https://docs.github.com/en/github/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)

@somya-15
Copy link
Contributor

Kindly suggest changes/corrections that we can make in the PR as we are unable to pass 3 tests as shown below:
Screenshot 2021-10-12 at 15 34 25

@smlambert
Copy link
Contributor

related: #107

@smlambert
Copy link
Contributor

The PR #107 was closed without being merged. Un-assigning and putting it back into the list of open / available good first issues.

@somya-15
Copy link
Contributor

somya-15 commented Mar 3, 2022

Can I (Somya-15) and Nandini(nandini-4120) be assigned this issue again as we are planning to make a fresh pull request and start over again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
4 participants