-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openj9-systemtest repo options #107
Add openj9-systemtest repo options #107
Conversation
see #94 (comment) For the ECA validation check failure above, one must ensure that the email address associated with the Eclipse account is the same as the one associated to the github ID / commit or the validation check will fail. |
The 3 failing checks are unrelated to this PR (related instead to adoptium/aqa-tests#2949). |
action.yml
Outdated
openj9-systemtestsRepo: | ||
description: 'Personal openj9-systemtests Repo' | ||
required: false | ||
default: 'openj9-systemtests:master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value is set up in aqa-tests repo there is no need to redo it in run-aqa. Similar to issue #105
src/runaqa.ts
Outdated
} | ||
|
||
function getOpenj9SystemTestsRepo(openj9systemtestsRepo: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar issue mentioned in #105.
Also openj9systemtests environment variable is
env.OPENJ9_SYSTEMTEST_REPO
env.OPENJ9_SYSTEMTEST_BRANCH
@Nandini-4120 Looks like your PR has a different whitespace setup, which means the whole .ts files were changed. Could you please update your configuration so the PR only shows your changes even without hiding whitespace changes? |
Hi |
Hi @Nandini-4120 - can you please resolve the conflicts in your branch (as some files have changed since you created your PR). thanks! |
Hi |
There are still conflicts need to be resolved. |
@sophia-guo, we are unable to identify other conflicts other than system checks. Kindly guide us in resolving the unidentified conflicts that are causing issues in merging our code. Thanking you. |
See Contributing.md - step 5 for ways to rebase a branch (or reference a git cheat sheet for ways to resolve conflicts in a branch, https://opensource.com/article/20/4/git-merge-conflict). |
…y : Nandini Taneja <[email protected]> Signed-off-by: Somya Tomar <[email protected]> Signed-off-by: Nandini-4120 <[email protected]>
Hi |
I will close this PR as stale and it now fails the ECA check because it picks up commits from sophia's old IBM email address which is no longer active. It also appears to contain merge conflict change lines. |
What GitHub issue does this PR apply to?
Resolves #94
What changed and why?
Made changes according to the issue description.