-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeType version used across Temurin versions is inconsistent #3504
Comments
Running the tooling produced as part of #3484 against JD11.0.21+9 the following was noted (using data from the SBOMs:
|
Trying to test whether using a different FreeType "system" version seems not easy. When using the build image and trying to reference a different FreeType other than the glibc 2.17 compatible one in the build container image, results in linking issues due to glibc linking. Similarly trying to build outside of docker it’s quite hard to replace a System FreeType due to it’s dependency links to other system components. From a Reproducible Build perspective, using a different system FreeType would probably not alter the binary. It is also going to be not relevant when moving to using a specific DevKit, where the system FreeType is in the DevKit. |
Not sure why we'd want to do that - the goal ought to be to use the bundled freetype and ship that library with the JDK. We absolutely should not be interfering with OS-installed libraries.
I'd dispute that - the headers are #included in the code so there's definitely a chance that different versions could make a difference to the binaries. |
I am trying to simply "prove" if using a different system FreeType would produce different binaries... so far I have not been able to do that..I can only use FreeType 2.8.0 which is the latest. It does not seem possible to go backwards... any ideas? |
@sxa Yes, I was absolutely wrong!
As can be seen libfontmanager.so differs due to the use of different "system" FreeType |
Which would lead me to say that we should be using the |
Yes I would agree, we'd be best using "bundled". I have just check some other Vendors, and jdk-21.0.1+12 for both Red Hat and Zulu both use "Bundled" FreeType:
|
As confirmed in the PMC, Temurin will change to use "bundled" FreeType from jdk-21.0.2 + |
Issue: #3493
highlighted the various Freetype versions used for Temurin versions, and the various different versions Temurin is built and linked with.
Should we look to provide a more consistent set of versions, and possibly use "Bundled" where possible?
The text was updated successfully, but these errors were encountered: