Use bundled zlib on all versions, not just 21 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart X Addison <[email protected]>
karianna
approved these changes
Aug 17, 2023
andrew-m-leonard
approved these changes
Aug 22, 2023
tellison
reviewed
Aug 22, 2023
Co-authored-by: Tim Ellison <[email protected]>
karianna
approved these changes
Aug 22, 2023
AdamBrousseau
added a commit
to AdamBrousseau/openjdk-build
that referenced
this pull request
Sep 6, 2023
Related adoptium#1951 adoptium#3399 adoptium#3459 Signed-off-by: Adam Brousseau <[email protected]>
|
@sxa could this be wrapped in an |
|
@AdamBrousseau sure. Please send a PR for that (although maybe a !OpenJ9 test rather than =Temurin to preserve the current behaviour for other users) |
AdamBrousseau
added a commit
to AdamBrousseau/openjdk-build
that referenced
this pull request
Sep 13, 2023
Related adoptium#3459 eclipse-openj9#18127 Signed-off-by: Adam Brousseau <[email protected]>
AdamBrousseau
added a commit
to AdamBrousseau/openjdk-build
that referenced
this pull request
Sep 13, 2023
Related adoptium#3459 eclipse-openj9/openj9#18127 Signed-off-by: Adam Brousseau <[email protected]>
sxa
pushed a commit
that referenced
this pull request
Sep 27, 2023
Related #3459 eclipse-openj9/openj9#18127 Signed-off-by: Adam Brousseau <[email protected]>
3 tasks
chadlwilson
added a commit
to chadlwilson/gocd
that referenced
this pull request
Aug 13, 2024
Previously system zlib was needed for the JVM, however Eclipse Temurin/Adoptium have changed to use bundled zlib for all runtimes some time in 2023: adoptium/temurin-build#3459 Additionally the version here was built by ArchLinux with https://gitlab.archlinux.org/archlinux/devtools/-/merge_requests/188 which needs glibc 2.36.0+ and thus has broken this zlib version whenever it is attempted to be used. (e.g if you try to use glibc AWS SDK layered on top of this image, you will get a crash `/aws/dist/aws: /usr/glibc-compat/lib/libc.so.6: version 'GLIBC_ABI_DT_RELR' not found (required by /usr/glibc-compat/lib/libz.so.1)`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1951