Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freetype: run bash autogen.sh before any ./configure commands #3523

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 6, 2023

ref #3509 (comment)

if ./configure --help is run before bash autogen.sh then we get

* module: psnames   (Postscript & Unicode Glyph name handling)
cd builds/unix; \
	        ./configure 
/bin/sh: ./configure: No such file or directory
make: *** [setup] Error 127

and therefore pngArg="--with-png=no" does not get set

Running it after the autogen.sh script works

bash-3.2$ arch -x86_64 ./configure --help | grep with-png
  --with-png=[yes|no|auto]

Needs testing in jenkins

@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites labels Nov 6, 2023
@Haroon-Khel
Copy link
Contributor Author

https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-temurin/427/ is queued up, link will be active when 426 finishes

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Haroon-Khel
Copy link
Contributor Author

From the jenkins link above, the --with-png value gets set correctly
21:30:14 pngArg value: --with-png=no

@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites and removed jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites labels Nov 7, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbin/prepareWorkspace.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites and removed jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites labels Nov 8, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to exit with an explicit code of 1 if the autogen.sh fails, but otherwise this is good to go.

@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites and removed jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites labels Nov 8, 2023
@Haroon-Khel Haroon-Khel merged commit 54ce302 into adoptium:master Nov 8, 2023
6 checks passed
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins Issues that enhance or fix our jenkins server testing Issues that enhance or fix our test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants