-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freetype: run bash autogen.sh before any ./configure commands #3523
Conversation
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-temurin/427/ is queued up, link will be active when 426 finishes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
From the jenkins link above, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and well spotted! Presumably we can remove https://github.com/adoptium/infrastructure/blob/ee8ecd8ddb812dd14641f557d3c3bb76f8a33097/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/MacOSX.yml#L183 when this goes in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be better to exit with an explicit code of 1
if the autogen.sh fails, but otherwise this is good to go.
ref #3509 (comment)
if
./configure --help
is run beforebash autogen.sh
then we getand therefore
pngArg="--with-png=no"
does not get setRunning it after the autogen.sh script works
Needs testing in jenkins