Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: how to add a one-off patch to a point release #3530

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 13, 2023

We do not currently have any documentation on the process for creating point releases in the adoptium mirror repositories. This adds in the information for a one off patch using a branch from a GA tag. A subsequent PR should create the equivalent doc for covering perpetual floating patches in the codebase.

Preview this change at https://github.com/sxa/temurin-build/blob/pointreleases1/RELEASING.md#summary-on-point-releases

@sxa sxa self-assigned this Nov 13, 2023
@github-actions github-actions bot added the documentation Issues that request updates to our documentation label Nov 13, 2023
@sxa sxa marked this pull request as draft November 13, 2023 12:52
@sxa
Copy link
Member Author

sxa commented Nov 13, 2023

Draft as this will need some input on how to handle testenv.properties which needs to have the new tag to avoid this at the start of the top level pipeline:
[ERROR] scmReference does not match with any JDK branch in testenv.properties in aqa-tests release branch. Please update aqa-tests v0.9.9-release release branch. Set the current build result to FAILURE!

Slack thread to discuss: https://adoptium.slack.com/archives/C09NW3L2J/p1699880299974419

@sxa sxa marked this pull request as ready for review November 13, 2023 15:12
@sxa sxa marked this pull request as draft November 13, 2023 15:27
@sxa
Copy link
Member Author

sxa commented Nov 13, 2023

Back in draft again pending understanding/documenting/resolving this:

14:40:15  checking for --with-version-string... <none>, default
14:40:15  configure: error: "12.1" is not a valid numerical value for VERSION_BUILD

@sxa sxa force-pushed the pointreleases1 branch 2 times, most recently from 39a7ec7 to 33bc3b5 Compare November 13, 2023 15:38
@sxa
Copy link
Member Author

sxa commented Nov 13, 2023

Back in draft again pending understanding/documenting/resolving this:

Added in note about --with-version-build when triggering the release pipeline to resolve this - removing draft status again.

@sxa sxa marked this pull request as ready for review November 13, 2023 15:40
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna karianna merged commit 08ef952 into adoptium:master Nov 13, 2023
6 checks passed
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues that request updates to our documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants