Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for brew update failure when running aqa smoke tests #3543

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

netomi
Copy link
Contributor

@netomi netomi commented Nov 23, 2023

The tests for macos-13 fail due to an error when setting up the smoke tests.

This seems to be a pretty common problem, e.g. as documented here:

https://github.com/actions/runner-images/issues/6817

Workaround seems to be to either ignore the error or remove the files before running brew if they are present.

@netomi netomi marked this pull request as ready for review November 23, 2023 18:35
@karianna
Copy link
Contributor

actions/setup-python#577 (comment) suggests forcing an overwrite instead?

@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites labels Nov 23, 2023
@netomi
Copy link
Contributor Author

netomi commented Nov 23, 2023

ideally that should be fixed in the runaqa action that calls brew install, this workaround is there to make the builds green as the macos13 build always seems to fail because of that.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites and removed macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites labels Nov 23, 2023
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-m-leonard andrew-m-leonard merged commit d23434c into adoptium:master Nov 30, 2023
23 checks passed
@andrew-m-leonard
Copy link
Contributor

Fixes #3550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues that affect or relate to the MAC OS testing Issues that enhance or fix our test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants