-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to download + SBOM validation scripts #3660
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
964660b
to
67095c7
Compare
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
When I started on this I thought it was going to be a simple fix but there ended up being quite a lot of changes and a couple of real bugs identified. This is now ready for review and merging after complying with the linter. I have verified it on all four release lines from January, and the only issue is with the sha checksum of jdk8/win32/MSI as linked in the description. Noting that the compilers checked for in these scripts should be kept in sync with https://github.com/adoptium/temurin-build/blob/master/FAQ.md#what-are-the-prerequisites-for-a-system-used-for-builds |
a8adb6e
to
d6d4cb9
Compare
Adding Andrew as reviewer as he volunteered yesterday :-) |
Post-GA fixes to the download + SBoM validation scripting introduced via #3484. Note that this does not address the other issues with this as per #3621 #3565
OpenJDK Source Commit
in the SBoM appears multiple times - this dedups before trying to use it in agrep
operation (!)Note that jdk8u402-b02 does not pass the tests due to an issue with the Win32 MSI checksum which has a path prefix on the filename. This has been raised at #3662
Related (and not addressed by this PR):