Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVT: Trap case where limited platforms mean no zip or no tgz exist in release #3798

Merged
merged 3 commits into from
May 18, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented May 7, 2024

Fixes adoptium/temurin#28 (comment)

Recommend reviewing ignoring whitespace as this is a simple change but adds indents due to the if section.

@sxa sxa self-assigned this May 7, 2024
@sxa sxa marked this pull request as ready for review May 7, 2024 18:11
@sxa sxa force-pushed the fix_download_verifier branch 5 times, most recently from 205b441 to f47cea4 Compare May 8, 2024 16:11
@sxa
Copy link
Member Author

sxa commented May 8, 2024

Also fixes #3801

I would normally have done this in a separate PR but I needed to test it all together to do it properly and this has only had one approval so far, therefore requesting @karianna to re-approve.

@sxa sxa requested a review from karianna May 8, 2024 16:23
@karianna
Copy link
Contributor

karianna commented May 8, 2024

In /github/workspace/tooling/release_download_test.sh line 214:
for A in ls -1d OpenJDK*.tar.gz OpenJDK*.zip *.msi *.pkg *sbom*[0-9].json; do
^-- SC2045 (warning): Iterating over ls output is fragile. Use globs.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks ....
^-- SC2035 (info): Use ./glob or -- glob so names with dashes won't become options.
^-- SC2035 (info): Use ./glob or -- glob so names with dashes won't become options.
^-- SC2035 (info): Use ./glob or -- glob so names with dashes won't become options.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter fixes needed

Signed-off-by: Stewart X Addison <[email protected]>
@karianna karianna merged commit c2d7c1b into adoptium:master May 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

General Retrospective for March/April 2024 Releases
3 participants