Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute permission to macos_repro_build_compare.sh #3924

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sophia-guo
Copy link
Contributor

Update mac script permission same as all other shell script files.

@sophia-guo sophia-guo requested a review from sxa August 22, 2024 16:57
@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Aug 22, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you update the commit message so it's a bit clearer in the history please e.g.
Add execute permission to macos_repro_build_compare.sh

@sophia-guo sophia-guo changed the title Adding execute permission Add execute permission to macos_repro_build_compare.sh Aug 22, 2024
@karianna karianna requested a review from sxa August 23, 2024 02:30
@gdams gdams merged commit cda8912 into adoptium:master Aug 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues that affect or relate to the MAC OS
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants