-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a didcomm pickup client javascript client component #7
Merged
Blindspot22
merged 26 commits into
main
from
Create-a-didcomm-pickup-client-javascript-client-component
Nov 19, 2024
Merged
Create a didcomm pickup client javascript client component #7
Blindspot22
merged 26 commits into
main
from
Create-a-didcomm-pickup-client-javascript-client-component
Nov 19, 2024
+8,739
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idcomm-pickup-client-javascript-client-component to use the didresolver to correctly create a didcomm-pickup-client-javascript component
…ient DIDs before processing messages.
Tekum-Emmanuella
requested review from
Christiantyemele,
Blindspot22 and
chendiblessing
November 11, 2024 14:04
Blindspot22
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Christiantyemele
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through the reviews here they are also repeating in your ticket
Christiantyemele
requested changes
Nov 14, 2024
chendiblessing
approved these changes
Nov 15, 2024
Christiantyemele
approved these changes
Nov 19, 2024
IngridPuppet
deleted the
Create-a-didcomm-pickup-client-javascript-client-component
branch
December 17, 2024 10:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces functions for constructing and securely sending DIDComm pickup requests, delivery requests, and message receipts. It includes encryption, message packing, and unpacking to enhance secure communication for a pickup-client javascript-client