-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #38 add config file #50
Open
ojob
wants to merge
20
commits into
adrienverge:master
Choose a base branch
from
ojob:feature-#38-add-config-file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m filesystem WARNING: this commit has not been tested (missing GTK dependencies) Format of the configuration is dict-based. Current implementation will use the YAML format. Signed-off-by: Joël BOURGAULT <[email protected]>
Also added usage of built-in `logging` module. WARNING: this commit has not been tested (missing GTK dependencies) Signed-off-by: Joël BOURGAULT <[email protected]>
WARNING: this has not been tested (missing GTK dependencies) Signed-off-by: Joël BOURGAULT <[email protected]>
I choose to make interface with other Gtk classes 'simpler', i.e. at a lower level: these do not access Options instance directly, but directly to parameters or to `parent` instance. WARNING: not tested yet (missing GTK dependencies) Signed-off-by: Joël BOURGAULT <[email protected]>
…ming. WARNING: not tested yet (missing GTK dependencies) Signed-off-by: Joël BOURGAULT <[email protected]>
Signed-off-by: Joël BOURGAULT <[email protected]>
WARNING: not tested (missing GTK dependencies) Signed-off-by: Joël BOURGAULT <[email protected]>
Signed-off-by: Joël BOURGAULT <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
And some other minor improvements. This commit has been tested, both with python2.7.13 and python3.5.3. Signed-off-by: Joël Bourgault <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Seems that I can't get the newlines right, according to If anyone gets how I can make this pass the checks, I'm all ears! |
Signed-off-by: Joël BOURGAULT <[email protected]>
Signed-off-by: Joël BOURGAULT <[email protected]>
Signed-off-by: Joël Bourgault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first commit to implement #38: addition of an
options.yml
file, that makes parameters persistent on user filesystem.User can modify the file then restart PhotoCollage; or user can modify the parameters through the settings dialog, then at exit, PhotoCollage will update the settings file.
This commit has been tested with python 2.7 and 3.5, and also with
flake8 .
andunittest
, with no warning/error reported.