Remove debugging code #1188
Merged
Remove debugging code #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `getsockopt()` calls introduced in adrienverge#799 to investigate the possible relation of TCP keep-alives with random disconnections. The retrieved values did not help, they only confuse us. I believe everything happens at the PPP level, with options `lcp-echo-interval` and `lcp-echo-failure`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
getsockopt()calls introduced in #799 to investigate the possible relation of TCP keep-alives with random disconnections.The retrieved values did not help, they only confuse us. I believe everything happens at the PPP level, with options
lcp-echo-intervalandlcp-echo-failure. See #1187 (comment).