PocketMine MP vulnerable to uncontrolled resource consumption via mismatched type of 'InventoryTransactionPacket'
Moderate severity
GitHub Reviewed
Published
May 30, 2023
in
pmmp/PocketMine-MP
•
Updated Jun 1, 2023
Package
Affected versions
< 4.18.0-ALPHA2
Patched versions
4.18.0-ALPHA2
Description
Published to the GitHub Advisory Database
Jun 1, 2023
Reviewed
Jun 1, 2023
Last updated
Jun 1, 2023
Impact
A "mismatch" type
InventoryTransactionPacket
is sent by the client to request a resync of all currently open inventories.Since PocketMine-MP does not rate-limit these "mismatch" transactions, and the syncing of inventories is not deferred until, e.g. the end of the current tick, they can be used as a very cheap bandwidth multiplier by making the server send out many MB of data (network serialized inventory items can be very large, especially when dealing with large amounts of NBT).
This is not currently known to have been exploited in the wild.
Patches
This problem was fixed in 4.18.0-ALPHA2 by ca6d51498f12427a947467da8fcad7811418e6cc alongside the introduction of the
ItemStackRequest
system implementation.Workarounds
Plugins can handle
DataPacketReceiveEvent
forInventoryTransactionPacket
and check if the type isMismatchTransactionData
. If it is, apply some kind of rate limit (e.g. max 1 per tick).References