mx-chain-go's relayed transactions always increment nonce
High severity
GitHub Reviewed
Published
Jul 13, 2023
in
multiversx/mx-chain-go
•
Updated Nov 4, 2023
Description
Published to the GitHub Advisory Database
Jul 13, 2023
Reviewed
Jul 13, 2023
Published by the National Vulnerability Database
Jul 13, 2023
Last updated
Nov 4, 2023
Impact
When executing a relayed transaction, if the inner transaction failed, it would have increased the inner transaction's sender account nonce. This could have contributed to a limited DoS attack on a targeted account. The fix is a breaking change so a new flag
RelayedNonceFixEnableEpoch
was needed. This was a strict processing issue while validating blocks on a chain.Patches
v1.4.17 and later versions contain the fix for this issue
Workarounds
there were no workarounds for this issue. The affected account could only wait for the DoS attack to finish as the attack was not free or to attempt to send transactions in a very fast manner so as to compete on the same nonce with the attacker.
References
For the future understanding of this issue, on v1.4.17 and onwards versions, we have this integration test that addresses the issue and tests the fix.
https://github.com/multiversx/mx-chain-go/blob/babdb144f1316ab6176bf3dbd7d4621120414d43/integrationTests/vm/txsFee/relayedMoveBalance_test.go#LL165C14-L165C14
References