Skip to content

Inability to de-op players if listed in ops.txt with non-lowercase letters

Low severity GitHub Reviewed Published Dec 16, 2021 in pmmp/PocketMine-MP • Updated Jan 9, 2023

Package

composer pocketmine/pocketmine-mp (Composer)

Affected versions

< 4.0.3

Patched versions

4.0.3

Description

Impact

Originally reported in iTXTech/Genisys#1188

PotterHarry98
potterharry98

deop PotterHarry98

will remove potterharry98 from the ops.txt but not PotterHarry98.

Operator permissions are checked using Config->exists() with lowercase=true, which will result in a match:
https://github.com/pmmp/PocketMine-MP/blob/22bb1ce8e03dba57173debf0415390511d68e045/src/utils/Config.php#L449

This means that it's possible to make yourself impossible to de-op (using commands) by adding your name to ops.txt with uppercase letters.

Patches

4d37b79ff7f9d9452e988387f97919a9a1c4954e

Workarounds

This can be easily addressed by removing the offending lines from ops.txt manually.

For more information

If you have any questions or comments about this advisory:

References

@dktapps dktapps published to pmmp/PocketMine-MP Dec 16, 2021
Reviewed Dec 16, 2021
Published to the GitHub Advisory Database Dec 16, 2021
Last updated Jan 9, 2023

Severity

Low

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Local
Attack complexity
Low
Privileges required
Low
User interaction
None
Scope
Unchanged
Confidentiality
Low
Integrity
None
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:N

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-j5qg-w9jg-3wg3

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.