Potentially sensitive data exposure in Symfony Web Socket Bundle
Moderate severity
GitHub Reviewed
Published
Jul 6, 2020
in
GeniusesOfSymfony/WebSocketBundle
•
Updated Jan 9, 2023
Package
Affected versions
< 1.10.4
>= 2.0.0, < 2.6.1
>= 3.0.0, < 3.3.0
Patched versions
1.10.4
2.6.1
3.3.0
Description
Reviewed
Jul 7, 2020
Published to the GitHub Advisory Database
Jul 7, 2020
Last updated
Jan 9, 2023
Impact
Inside
Gos\Bundle\WebSocketBundle\Server\App\Dispatcher\TopicDispatcher::onPublish()
, messages are arbitrarily broadcasted to the related Topic ifGos\Bundle\WebSocketBundle\Server\App\Dispatcher\TopicDispatcher::dispatch()
does not succeed. Thedispatch()
method can be considered to not succeed if (depending on the version of the bundle) the callback defined on a topic route is misconfigured, aGos\Bundle\WebSocketBundle\Topic\TopicInterface
implementation is not found for the callback, a topic which also implementsGos\Bundle\WebSocketBundle\Topic\SecuredTopicInterface
rejects the connection, or an Exception is unhandled. This can result in an unintended broadcast to the websocket server potentially with data that should be considered sensitive.Patches
In 1.10.4, 2.6.1, and 3.3.0,
Gos\Bundle\WebSocketBundle\Server\App\Dispatcher\TopicDispatcher::onPublish()
has been changed to no longer broadcast an event's data ifGos\Bundle\WebSocketBundle\Server\App\Dispatcher\TopicDispatcher::dispatch()
fails.Workarounds
Upgrade to 1.10.4, 2.6.1, and 3.3.0
Note, the 1.x branch is considered end of support as of July 1, 2020.
For more information
If you have any questions or comments about this advisory:
References