Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection form "Enter" to submit instead of delete #1252

Closed
wants to merge 1 commit into from

Conversation

nichwall
Copy link
Contributor

Fixes #1158

This PR switches the order of the "delete" and "submit" buttons for editing a server connection, then uses flex-row-reverse to keep the UI looking the same.
Pressing "enter" while being focused on the password field now submits and attempts a connection instead of trying to delete the server config.

Tested on Android, Pixel 6a.

@advplyr
Copy link
Owner

advplyr commented Jul 8, 2024

The better way to handle this is to set the button to type="button". The other ui-btn component takes a prop type so that would need to also be added to the ui-icon-btn. I can do that actually it will only take a min

@nichwall
Copy link
Contributor Author

nichwall commented Jul 8, 2024

Sounds good. Thanks for fixing these little code things I try. Feel free to just close the PR if you do it in another commit.

@advplyr
Copy link
Owner

advplyr commented Jul 8, 2024

I got it here 03a46de
I set the default for the icon btn to be type "button" because it made sense.

@advplyr advplyr closed this Jul 8, 2024
@nichwall nichwall deleted the switch_login_buttons branch July 8, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login on iOS using enter button defaults to “Remove this server config?” instead of logging in
2 participants