AMT V4 Flatfile generation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… delete it you cannot deplpoy a new one anymore. Just sad
…s are now reporting an extra fail because I'm now logging no TP for a TPUU as a junit test fail
…International file naming
A new field 'ingredients' added to Concept class and 'addIngredient' method introduced to handle the Concept's ingredients. The error messages for failure scenarios during file processing in AmtCache class have also been enhanced to display the full row information. Besides, various scenarios are handled for MES Product (MP) parents based on their ingredients and exceptions are thrown accordingly along with logging warnings in Amt2FlatFile class. New active ingredient types added to the AttributeType class.
Add back Junit XML generation
Updated the FileFormat class to correctly handle quoting for TSV files by returning an empty string for field quotes. Adjusted test data to reflect changes in the expected output.
TSV quoting fix
Updated Amt2FlatFile to use write method with DOS line termination for consistency. Refactored Amt2FlatFileTest to improve readability and ensure proper file handling during tests.
Replaced manual getter and setter methods with Lombok annotations for brevity. Refactored logging to use constants where possible and simplified the code structure for improved readability. Removed unused imports and adjusted formatting for better consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done