Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Port in multi comparison matrix into visualisation module #2343

Merged
merged 13 commits into from
Nov 14, 2024

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Nov 11, 2024

Fixes #1463

Ported in from https://github.com/MSD-IRIMAS/Multi_Comparison_Matrix

changes:

  1. I have made all the utility functions private and put them in the same file
  2. I have simply removed the soft dependency on baycomp and another on a progress bar. Latter is not needed. Former is not needed by me at the moment, and a new soft dep should be after some discussion.
  3. Removed parameters associated with bayesian things
  4. Changed default save_json to false
  5. Added minimal testing, probably needs more for coverage
  6. Added example at the end of examples/visualisation/plotting_results.ipynb

@TonyBagnall TonyBagnall added the visualisation Visualisation module label Nov 11, 2024
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 11, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#FBCA04}{\textsf{visualisation}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@TonyBagnall TonyBagnall changed the title [ENH] Port in mcm [ENH] Port in multi comparison matrix into visualisation module Nov 12, 2024
@TonyBagnall TonyBagnall marked this pull request as ready for review November 12, 2024 15:31
@TonyBagnall
Copy link
Contributor Author

@hadifawaz1999 feel free to jump in and make your changes

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! good to have this in before 1.0

@TonyBagnall TonyBagnall merged commit 1fa5f54 into main Nov 14, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/mcm branch November 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement visualisation Visualisation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Implement the Multi Comparison Matrix in visualization module
2 participants