This repository has been archived by the owner on Aug 4, 2018. It is now read-only.
Chaos, Random Pack, Autopick, Suggest Lands, Makefile, add SOI #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an attempt to run `node app.js` would fail with this
mysterious and wholly unhelpful error:
undefined:24786
throw errorReporter.errors;
^
<compile-source>:73:9: Duplicate declaration, specialrnd
Evidently, a declaration is duplicated if it is made across case bodies.
When hovered over, cards now turn slightly brighter. Additionally, the user can click a card to set it to be autopicked. The card then stays highlighted, and has the text 'autopick' on its bottom border. If the user picks another card, the old card is returned to normal and the new assumes autopick behavior.
When the user selects a card for autopicking, but then their time expires, the server automatically picks the autopick card on their behalf rather than picking a card at random. This is behavior similar to that of MTGO. If the user fails to select any card at all, the old behavior applies and one is selected at random.
Autopick, DFC fixes, MTGJSON change
This indicator simply displays 'Y' or 'N' if the given user is currently connected.
The icon is green for currently-connected players, black for disconnected players, and gray for bots. Note that green/red for the indicator would probably be a bad choice for red-green colorblind players. Each indicator has hover text explaining its meaning.
This is useful if you want to run `make` with the `-j` option to speed up things somewhat. (It also helps to not confuse people like me who have `make` aliased to `make -j5`, for whom the build process doesn't quite work.)
Note that this commit requires a rebuild of the cards JSON files, as it now records each card's mana cost.
Each player must select their 'ready' checkbox before the game can start.
The host can kick users before the game has started or during the game. If a user is kicked beforehand, they leave the game and can be replaced with a new user. If a user is kicked during the game, they make all future picks at random.
Suggest lands
dev-id
changed the title
|
#1 #145 |
This merge includes a few fixups: * Keep the default port of 1337. * Don't include branding changes. * Minor style changes.
Also adjust the rest of the text for stylistic purposes.
…s-master Conflicts: public/src/components/lobby.js src/bot.js src/game.js src/make/cards.js src/pool.js src/util.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.