This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
refactor(core): move schemaDefinitions helpers to graphback-core #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR was created because non-core plugins to not have access to helpers to create CRUD types. This ability was isolated to the
graphback-codegen-schemaplugin. This was an attempt to fix #2118 but unfortunately it is only partially fixed. Because GraphQL Compose removes unused types between plugins, all unused inputs are removed, including scalar filter inputs. In theory with this PR they can now be recreated.This also fixes #2117 in the DataSyncPlugin but removes unused types at the end of the plugin chain in
GraphbackCoreMetadata