Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix: remove conditional requiring 'items' for path arg to get count #2297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CoreyKovalik
Copy link
Collaborator

Types of changes

Using the context.graphback.Model.findBy method should not require a path arg to get the count back.

requestedCount was returning false always if "items" was not passed as an argument to findBy in a custom resolver.

// would not return count, even if requested
await context.graphback.Model.findBy(args, context, info);

// this was required to get count back, which doesn't make much sense
await context.graphback.Model.findBy(args, context, info, 'items');
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Verification

Tested manually with custom resolvers.

Further comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant