fix: TOOLS-2996 ns SC check for manage roster stage observed #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-spiker
changed the title
- check if ns is SC - catches exception while SC check - fix the existing test cases for new SC check
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 92 92
Lines 21226 21261 +35
=======================================
+ Hits 14547 14571 +24
- Misses 6679 6690 +11 ☔ View full report in Codecov by Sentry. |
|
removed the string check for unstable cluster and generalised the errors to proceed further in roster management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following check before running
manage roster stage observed ns testnamespace should exist and namespace should be SC enabled.