APPS-1325 Delete failed backups #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #247 +/- ##
==========================================
+ Coverage 28.04% 28.09% +0.05%
==========================================
Files 39 39
Lines 2168 2189 +21
==========================================
+ Hits 608 615 +7
- Misses 1475 1489 +14
Partials 85 85 ☔ View full report in Codecov by Sentry. |
reugn
approved these changes
Nov 5, 2024
pkg/service/client_manager.go
Outdated
| @@ -73,17 +99,21 @@ func (cm *ClientManagerImpl) GetClient(cluster *model.AerospikeCluster) (*backup | |||
| } | |||
|
|
|||
| // getExistingClient tries to get an existing client from the cache. | |||
| // Returns nil if client doesn't exist. | |||
| func (cm *ClientManagerImpl) getExistingClient(cluster *model.AerospikeCluster) *backup.Client { | |||
| // Returns nil if client doesn't exist, error is client is not connected. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is fixing unstable integration tests after introducing client cache