Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KO-251: Added auth sub-command to grant RBAC access #6

Merged
merged 7 commits into from
Sep 28, 2023
Merged

KO-251: Added auth sub-command to grant RBAC access #6

merged 7 commits into from
Sep 28, 2023

Conversation

abhishekdwivedi3060
Copy link
Contributor

@abhishekdwivedi3060 abhishekdwivedi3060 commented Aug 14, 2023 •
edited
Loading

  • Added auth sub-command to grant RBAC access
  • Added auth env-test
  • Fixed logging
  • Refactored existing code

tanmayja
tanmayja requested changes Sep 11, 2023
View reviewed changes
README.md Outdated
* If **cluster-scope** flag is set, user should have the CREATE, GET, UPDATE and DELETE permission for ServiceAccount and ClusterRoleBinding.

#### Collect cluster info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change heading

README.md Outdated
```

#### Collect cluster info using krew
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change heading

tanmayja
tanmayja reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tanmayja tanmayja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User can give namespace which is not present in cluster. Specially in clustering we make lot of unnecessary info calls for that namespace and error out, can we check namespace existence beforehand to avoid this calls in both subcommands.

@sud82 sud82 merged commit 968e1ec into main Sep 28, 2023
1 check passed
@sud82 sud82 deleted the KO-251 branch September 28, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sud82 sud82 sud82 approved these changes

@tanmayja tanmayja tanmayja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekdwivedi3060 @sud82 @tanmayja