[KO-259] Changing ports for headless service. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayja
requested review from
sud82 and
abhishekdwivedi3060
as code owners
abhishekdwivedi3060
requested changes
Sep 14, 2023
…t of rack level reconciliation.
abhishekdwivedi3060
requested changes
Sep 20, 2023
abhishekdwivedi3060
approved these changes
Sep 28, 2023
Adding tests to validate pod service port and headless service port, to keep it simple. |
abhishekdwivedi3060
requested changes
Sep 29, 2023
Comment on lines
+421
to
+428
| if portSet.Has(p.Port) { | ||
| portSet.Delete(p.Port) | ||
| } | ||
| } | ||
|
|
||
| if portSet.Len() > 0 { | ||
| return fmt.Errorf("service %s port not configured correctly", serviceNamespacesName.Name) | ||
| } |
There was a problem hiding this comment.
nit: why not just check and move the portSet outside of for loop
if !portSet.Has(p.Port) {
return fmt.Errorf()
}
There was a problem hiding this comment.
multiple ways to implement this anyway, here just didn't want to return error if any port is also available in port list other than the required ones. I know in test cases it will not happen.
abhishekdwivedi3060
approved these changes
Oct 1, 2023
sud82
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing ports for headless service when moving tls to non-tls and vice versa