Maintain supported images in '/images' directory #56

kportertx · 2023-11-03T01:16:53Z

Also add support for ubi images.

…rsions.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

data/config/6.0/config.sh|8 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config_federal.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/6.2/config_federal.sh|1 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config_federal.sh|2 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/6.2/config.sh|1 col 1| c_editions appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|3 col 1| c_distros appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|4 col 1| c_distro_default appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|5 col 1| c_distro_bases appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|7 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/6.2/config.sh|8 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/6.1/config.sh|1 col 1| c_editions appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|3 col 1| c_distros appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|4 col 1| c_distro_default appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|5 col 1| c_distro_bases appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|7 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/6.1/config.sh|8 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config_federal.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/6.4/config_federal.sh|1 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config_federal.sh|2 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/6.4/config.sh|1 col 1| c_editions appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|3 col 1| c_distros appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|4 col 1| c_distro_default appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|5 col 1| c_distro_bases appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|7 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/6.4/config.sh|8 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2148
data/config/5.7/config.sh|1 col 1| c_editions appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|3 col 1| c_distros appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|4 col 1| c_distro_default appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|5 col 1| c_distro_bases appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|7 col 1| c_archs appears unused. Verify use (or export if used externally). SC2034
data/config/5.7/config.sh|8 col 1| c_platforms appears unused. Verify use (or export if used externally). SC2034

lib/log.sh

lib/globals.sh

data/config/6.0/config.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shfmt

build.sh

images/5.7/enterprise/el8/entrypoint.sh

images/6.0/community/el8/entrypoint.sh

images/6.0/enterprise/debian11/entrypoint.sh

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

hadolint

images/6.4/enterprise/el9/Dockerfile|8 col 1| Always tag the version of an image explicitly
images/6.4/enterprise/el9/Dockerfile|34 col 1| Specify version with dnf install -y <package>-<version>.
images/6.4/federal/el9/Dockerfile|8 col 1| Always tag the version of an image explicitly
images/6.4/federal/el9/Dockerfile|34 col 1| Specify version with dnf install -y <package>-<version>.

images/5.7/community/el8/Dockerfile

images/5.7/enterprise/el8/Dockerfile

images/6.0/community/el8/Dockerfile

images/6.3/enterprise/el9/Dockerfile

images/6.3/federal/el9/Dockerfile

images/6.4/community/el9/Dockerfile

lib/support.sh

images/6.4/enterprise/el9/Dockerfile

images/6.4/federal/el9/Dockerfile

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shfmt

images/6.0/enterprise/debian11/entrypoint.sh

images/6.0/enterprise/el8/entrypoint.sh

images/6.0/federal/el8/entrypoint.sh

images/6.1/community/debian11/entrypoint.sh

update.sh

data/template/0/Dockerfile.template

data/config/redhat/config.sh

data/config/dockerhub/config.sh

update.sh

test.sh

build.sh

update.sh

build.sh

update.sh

This reverts commit 59905bf.

kportertx added 14 commits October 30, 2023 17:37

WIP - change model to have scripts update/build/test all supported ve…

0735ac1

…rsions.

WIP - update, build, test working.

f932cc4

Support multiple distros.

fda533a

WIP - add ubi base images.

bd71fb9

UBI images are now working.

14e1391

Move bake.hcl to build.

e27aeb6

Combine the bake files.

e719b17

Fix target names.

b20128c

Cleanup project root.

3659773

Cleanup images.

6ea8d6c

Update readme.

9ddfbcf

Fix various ubi build issues.

ed8070b

Update github actions.

481cbd0

Fix test.sh.

c3c102f

github-actions bot reviewed Nov 3, 2023

View reviewed changes

Review changes.

e835d14

github-actions bot reviewed Nov 3, 2023

View reviewed changes

lib/support.sh Outdated Show resolved Hide resolved

Review changes.

76585fd

github-actions bot reviewed Nov 3, 2023

View reviewed changes

images/6.4/enterprise/el9/Dockerfile Outdated Show resolved Hide resolved

images/6.4/enterprise/el9/Dockerfile Outdated Show resolved Hide resolved

images/6.4/federal/el9/Dockerfile Outdated Show resolved Hide resolved

images/6.4/federal/el9/Dockerfile Outdated Show resolved Hide resolved

github-actions bot reviewed Nov 3, 2023

View reviewed changes

Review changes.

50dd2bf

github-actions bot reviewed Nov 3, 2023

View reviewed changes

update.sh Outdated Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

kportertx added 4 commits November 2, 2023 18:38

Review changes.

7e1c966

Review changes.

b7af8e2

Add cleanup for rpm builds - only leave two rpm builds for debugging.

78173df

XXX Run as the 'aerospike' user.

04fab3e

github-actions bot reviewed Nov 3, 2023

View reviewed changes

data/template/0/Dockerfile.template Show resolved Hide resolved

Minimum version supported by scripts is now 5.7.

94973ef

github-actions bot reviewed Dec 5, 2023

View reviewed changes

data/config/redhat/config.sh Show resolved Hide resolved

data/config/dockerhub/config.sh Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

kportertx added 4 commits December 5, 2023 12:11

Minor param update.

4122a17

Remove 'eval_features.conf' which is needed for version prior to 6.1.

dc0a734

Fix issue with merge.

8ed511a

Add 7.0.

32116ec

github-actions bot reviewed Dec 6, 2023

View reviewed changes

test.sh Outdated Show resolved Hide resolved

kportertx added 5 commits December 5, 2023 19:13

Autoreview changes.

d45065d

Also add 7.0 to redhat.

2dbadc9

Editorconfig corrections.

84caccc

Add automated redhat tests.

cc1f267

Add filter options to 'update.sh'.

aed4dd3

github-actions bot reviewed Dec 6, 2023

View reviewed changes

build.sh Outdated Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

update.sh Outdated Show resolved Hide resolved

github-actions bot reviewed Dec 6, 2023

View reviewed changes

build.sh Show resolved Hide resolved

Autoreview changes.

6a4550d

github-actions bot reviewed Dec 6, 2023

View reviewed changes

update.sh Outdated Show resolved Hide resolved

kportertx added 15 commits December 6, 2023 15:08

Autoreview changes.

264c3d4

Remove filter options from 'build.sh' and fix gh actions redhat tests.

1cdd99d

Merge remote-tracking branch 'origin/master' into version-dirs

ccd15d6

Add filtering options back to build script.

47be133

Merge branch 'master' into version-dirs

aa4f02c

Merge remote-tracking branch 'origin/master' into version-dirs

024d9d4

Merge remote-tracking branch 'origin/master' into version-dirs

ed34057

Reviewdog.

19911b1

README.md

59905bf

Revert "README.md"

f40b633

This reverts commit 59905bf.

Merge remote-tracking branch 'origin/master' into version-dirs

9081ebd

Add 7.1.

6e7c612

Merge remote-tracking branch 'origin/master' into version-dirs

3cb80cf

Update version regex to allow more version suffixes.

ba4080a

Nicer failed download messages.

f0a4e71

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maintain supported images in '/images' directory #56

Maintain supported images in '/images' directory #56

kportertx commented Nov 3, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Maintain supported images in '/images' directory #56

Are you sure you want to change the base?

Maintain supported images in '/images' directory #56

Conversation

kportertx commented Nov 3, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment