Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.9.0 and rename proximus to AVS #43

Conversation

davi17g
Copy link
Contributor

@davi17g davi17g commented Jul 8, 2024

No description provided.

@davi17g davi17g changed the title Update to 0.5.0 abd rename proximus to AVS Update to 0.5.0 and rename proximus to AVS Jul 8, 2024
@davi17g davi17g marked this pull request as ready for review July 18, 2024 09:54
@davi17g davi17g changed the title Update to 0.5.0 and rename proximus to AVS Update to 0.9.0 and rename proximus to AVS Jul 18, 2024
Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be conflicts with my branch that will need to be resolved

Copy link
Contributor

@arrowplum arrowplum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values had broken old config. Updated and added a few explicit versions. Narrowly looking at the k8s section now is working.

@@ -33,7 +33,7 @@ aerospikeVectorSearchConfig:
- aerocluster-0-0.aerocluster.aerospike.svc.cluster.local:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helm chart doesn't work for me with the new server. The problem is metadata-namespace was moved up to the service context https://aerospike.atlassian.net/wiki/spaces/VEC/pages/3575906306/Notable+changes+in+0.9.0+from+0.4.0#AVS-configuration

@jdogmcsteezy jdogmcsteezy changed the base branch from main to VEC-218-update-1.0 July 24, 2024 01:36
@jdogmcsteezy
Copy link

@davi17g I changed the base branch to VEC-218-update-1.0 and handled merge conflicts. If you have this merged into VEC-218-1.0 I can merge the final PR early tomorrow morning 8 AM PST

@davi17g
Copy link
Contributor Author

davi17g commented Jul 24, 2024

@hev Can you please take a look? and approve the PR?

Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just retested. Ready for merging.

@jdogmcsteezy jdogmcsteezy merged commit dacbb2e into VEC-218-update-1.0 Jul 24, 2024
1 check passed
@jdogmcsteezy jdogmcsteezy deleted the VEC-214-update-docker-compose-files-to-reference-0-5-image branch July 24, 2024 14:51
jdogmcsteezy pushed a commit that referenced this pull request Jul 24, 2024
* move non-customer facing images into internal folder

* Update to 0.9.0 and rename proximus to AVS (#43)

* Update README.md

* added explicit versions and fixed configuration for 0.9.0

---------

Co-authored-by: Joe Martin <[email protected]>
Co-authored-by: Jesse Schmidt <[email protected]>
Co-authored-by: David Gerchikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants