Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet-web-extension): use vue-cli-plugin-browser-extension #1393

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jan 27, 2022

depends on #1395

@davidyuk davidyuk force-pushed the feature/refactor-extension branch 2 times, most recently from a451567 to d3538b4 Compare January 27, 2022 07:49
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1393 (02110d0) into develop (da6a868) will decrease coverage by 5.33%.
The diff coverage is n/a.

❗ Current head 02110d0 differs from pull request most recent head 9f2f22a. Consider uploading reports for the commit 9f2f22a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1393      +/-   ##
===========================================
- Coverage    87.90%   82.57%   -5.34%     
===========================================
  Files           55       55              
  Lines         3110     3094      -16     
  Branches        40       40              
===========================================
- Hits          2734     2555     -179     
- Misses         355      521     +166     
+ Partials        21       18       -3     
Impacted Files Coverage Δ
src/utils/keystore.js 16.07% <0.00%> (-80.36%) ⬇️
src/utils/hd-wallet.js 21.56% <0.00%> (-74.51%) ⬇️
src/tx/tx-object.js 57.89% <0.00%> (-36.85%) ⬇️
src/utils/crypto.js 75.00% <0.00%> (-23.62%) ⬇️
src/utils/amount-formatter.ts 44.82% <0.00%> (-20.69%) ⬇️
src/utils/bytes.ts 68.42% <0.00%> (-10.53%) ⬇️
src/tx/builder/helpers.js 88.60% <0.00%> (-10.13%) ⬇️
src/utils/errors.ts 60.13% <0.00%> (-7.98%) ⬇️
src/account/memory.js 95.83% <0.00%> (-4.17%) ⬇️
src/tx/builder/index.js 81.45% <0.00%> (-1.33%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6a868...9f2f22a. Read the comment docs.

@davidyuk davidyuk marked this pull request as ready for review January 27, 2022 12:02
@marc0olo marc0olo self-requested a review January 28, 2022 09:20
@davidyuk davidyuk merged commit 899f4e5 into develop Jan 28, 2022
@davidyuk davidyuk deleted the feature/refactor-extension branch January 28, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants