Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wallet account view 2 #608

Closed
wants to merge 45 commits into from
Closed

feat: Wallet account view 2 #608

wants to merge 45 commits into from

Conversation

janmichek
Copy link
Collaborator

Description

fixes #536

There are 2 minor UX issues I will try to resolve in the following (Portfolio) issue, so I don't block the review

  1. After successful wallet connection there is no loader when redirecting to connected account detail
  2. When clicking on Try again, the whole page gets reloaded, which is not necessary. Only scanning again should work, but for some reason it's not working Wallet re-connection #572

Demo

firefox_BZzKh8r8cp.mp4

Checklist:

@janmichek
Copy link
Collaborator Author

@michele-franchi has been already approved by Liubov. Check the convo in #549

@janmichek
Copy link
Collaborator Author

previews has not been built.

@janmichek janmichek closed this Mar 11, 2024
@janmichek
Copy link
Collaborator Author

Let's continue here #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet account view
1 participant