AYS-569 | Fixed code review discussions

afet-yonetim-sistemi · Dec 22, 2024 · 524441c · 524441c
1 parent 0a54684
commit 524441c
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/src/test/java/org/ays/auth/controller/AysAuthEndToEndTest.java b/src/test/java/org/ays/auth/controller/AysAuthEndToEndTest.java
@@ -136,19 +136,16 @@ void givenValidForgotPasswordRequest_whenUserHasNotPasswordAndPasswordCreatedWit
 
         // Initialize
         Institution institution = new InstitutionBuilder()
-                .withId(AysValidTestData.SuperAdmin.INSTITUTION_ID)
+                .withId(AysValidTestData.Admin.INSTITUTION_ID)
                 .build();
 
-        AysRole role = roleReadPort.findAllActivesByInstitutionId(institution.getId())
-                .stream()
-                .findFirst()
-                .orElseThrow();
+        List<AysRole> roles = roleReadPort.findAllActivesByInstitutionId(institution.getId());
 
         AysUser user = userSavePort.save(
                 new AysUserBuilder()
                         .withValidValues()
                         .withoutId()
-                        .withRoles(List.of(role))
+                        .withRoles(roles)
                         .withInstitution(institution)
                         .build()
         );
@@ -193,13 +190,10 @@ void givenValidForgotPasswordRequest_whenUserHasPasswordAndPasswordCreatedWithLa
 
         // Initialize
         Institution institution = new InstitutionBuilder()
-                .withId(AysValidTestData.SuperAdmin.INSTITUTION_ID)
+                .withId(AysValidTestData.Admin.INSTITUTION_ID)
                 .build();
 
-        AysRole role = roleReadPort.findAllActivesByInstitutionId(institution.getId())
-                .stream()
-                .findFirst()
-                .orElseThrow();
+        List<AysRole> roles = roleReadPort.findAllActivesByInstitutionId(institution.getId());
 
         AysUser.Password password = new AysUserBuilder.PasswordBuilder()
                 .withValidValues()
@@ -210,7 +204,7 @@ void givenValidForgotPasswordRequest_whenUserHasPasswordAndPasswordCreatedWithLa
                 new AysUserBuilder()
                         .withValidValues()
                         .withoutId()
-                        .withRoles(List.of(role))
+                        .withRoles(roles)
                         .withInstitution(institution)
                         .withPassword(password)
                         .build()