Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-551 | The Email Validation Fixed. #399

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

MenekseYuncu
Copy link
Contributor

@MenekseYuncu MenekseYuncu commented Nov 12, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

agitrubard
agitrubard previously approved these changes Nov 20, 2024
@hakancivelek hakancivelek requested review from hakancivelek and removed request for hakancivelek November 20, 2024 13:41
@agitrubard agitrubard self-requested a review November 21, 2024 09:21
@agitrubard
Copy link
Collaborator

@MenekseYuncu commitler yanlış yere geldi. Bunun için özür diliyorum. Geri aldım ✅

alpemreelmas
alpemreelmas previously approved these changes Nov 25, 2024
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmailAddress anotasyonunun kullanıldığı bütün yerlerdeki testleri güncelledik mi?

egehanasal
egehanasal previously approved these changes Nov 26, 2024
Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmailAddress anotasyonunun kullanıldığı bütün yerlerdeki testleri güncelledik mi?

@MenekseYuncu MenekseYuncu merged commit 9976a1b into main Nov 28, 2024
1 check passed
@MenekseYuncu MenekseYuncu deleted the AYS-551/fixing-email-validation branch November 28, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants