Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-415 | Update 415 Error Header to Return API_ERROR Instead of VALIDATION_ERROR #421

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

yagmurbarank
Copy link
Contributor

@yagmurbarank yagmurbarank commented Dec 25, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@MenekseYuncu
Copy link
Contributor

Merhaba @yagmurbarank
Description kısmındaki [x ] -> [x] yaparak formatlayabilir misin? Ayrıca, Reviewers kısmına diğer herkesi de ekleyebilir misin?

Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yagmurbarank pull request başlığını aşağıdaki şekilde değiştirmemiz daha iyi olabilir ✅

AYS-415 | Unsupported Media Type Error Header Changed to API_ERROR

• Issue numarasından sonra bir boşluk bırakılmış olması daha düzenli görünmesini sağlar. Pull request başlık standartlarının yazdığı dokümanı inceleyebilirsin
• API_ERROR kod bloğu olarak (`` işaretiyle) belirtilmiş, bu da teknik terimin daha belirgin hale gelmesini sağlar

@yagmurbarank yagmurbarank changed the title AYS-415| Unsupported Media Type Error Header Changed to API ERROR AYS-415 | 415 Error: Update Header to Return API_ERROR Instead of VALIDATION_ERROR" Dec 26, 2024
@yagmurbarank yagmurbarank changed the title AYS-415 | 415 Error: Update Header to Return API_ERROR Instead of VALIDATION_ERROR" AYS-415 | 415 Error: Update Header to Return "API_ERROR" Instead of "VALIDATION_ERROR" Dec 26, 2024
@agitrubard agitrubard changed the title AYS-415 | 415 Error: Update Header to Return "API_ERROR" Instead of "VALIDATION_ERROR" AYS-415 | Update 415 Error Header to Return API_ERROR Instead of VALIDATION_ERROR Dec 26, 2024
@yagmurbarank yagmurbarank merged commit f4b920f into main Dec 26, 2024
5 checks passed
@yagmurbarank yagmurbarank deleted the AYS-415 branch December 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants