Fixes #13
Merged
Fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional fix included in this request: In |
blschatz
pushed a commit
that referenced
this pull request
Oct 21, 2019
* Added /build/ directory to .gitignore * Fixed bug initialising aff4.LogicalImage instances * fixed bugs in extract() * fixed aff4.extractAll() NameError exeption * Fix call to extractAll function This patch is partially necessary to correct the `--extract-all` flag. With this correction, `--extract-all` will work if there were no directories ingested from an input zip. Issue 15 reports on the problem with directories from an ingested zip. #15 This patch builds on Pull Request 13, as I'd also found the binary- output mode was necessary, though in a different spot. #13 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues:
#11:
aff4.LogicalImage.__init__()requires the container as first parameter. However, several functions in container.py (inLogicalImageContainer.images(),PreStdLogicalImageContainer.images()andPreStdLogicalImageContainer.open()) were missing that parameter (self), producing an exception when invoked as missing a positional argument.#12:
aff4.extract()andaff4.extractAll()functions were callingaff4.printVolumeInfo()passing the undefined variablefile. Fixed passing the original file name of the container.