Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web) restore type checking for production build #1625

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix(web) restore type checking for production build #1625

merged 3 commits into from
Sep 24, 2024

Commits on Sep 21, 2024

  1. fix(web): add @types/react as an explicit dev dep

    @dgdavid
    dgdavid committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    cf0f214 View commit details
    Browse the repository at this point in the history

  2. fix(web): add @types/react-dom as an explicit dev dep

    @dgdavid
    dgdavid committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    5cec710 View commit details
    Browse the repository at this point in the history

  3. fix(web): restore type checking for production build 

    Because, as said in ts-loader documentation,

> You probably don't want to give up type checking; that's rather the
> point of TypeScript.

https://github.com/TypeStrong/ts-loader?tab=readme-ov-file#faster-builds
    @dgdavid
    dgdavid committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    ebe8b5e View commit details
    Browse the repository at this point in the history