Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(storage): config support for generate section #1634

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Sep 24, 2024

Add support to the storage config for using a generate section for partitions and logical volumes.

{
  "partitions": [
    { "generate": "default" }
  ]
}
{
  "logicalVolumes": [
    {
      "generate": {
        "logicalVolumes": "mandatory",
        "stripes": 8
      }
    },
    {
      "filesystem": { "path": "swap" },
      "size": "8 GiB"
    }
  ]
}
  • The generate section is replaced by the default or mandatory volumes defined by the product.
  • If any volume is explicitly indicated in any device, then that volume is not added again by the generate section.

@coveralls
Copy link

coveralls commented Sep 24, 2024

Coverage Status

coverage: 72.152%. remained the same
when pulling 0a2922d on joseivanlopez:storage-volume-keywords
into 1e736e3 on openSUSE:master.

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11182376605

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 70.324%

Files with Coverage Reduction New Missed Lines %
rust/agama-cli/src/main.rs 6 0.0%
Totals Coverage Status
Change from base Build 11070850022: -0.1%
Covered Lines: 15640
Relevant Lines: 22240

💛 - Coveralls

@joseivanlopez joseivanlopez force-pushed the storage-volume-keywords branch 2 times, most recently from 7dc2b80 to 4d82fe7 Compare September 26, 2024 12:10
@joseivanlopez joseivanlopez marked this pull request as ready for review September 26, 2024 12:33
@joseivanlopez joseivanlopez force-pushed the storage-volume-keywords branch 2 times, most recently from 7efe886 to ea47bd4 Compare September 27, 2024 08:24
@joseivanlopez joseivanlopez changed the title feature(storage): config support for volume keywords feature(storage): config support for generate section Sep 27, 2024
@mvidner

This comment was marked as resolved.

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 6cb7771 into agama-project:master Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants