Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix localization of overview headers #1645

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Sep 27, 2024

Problem

Related to #1629.

Overview headers are not translated.

Solution

Do not call _() at module level (see #1643).

Testing

  • Tested manually

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit ded8adb into master Sep 27, 2024
1 check passed
@imobachgs imobachgs deleted the fix-overview-headers branch September 27, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants