Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Do not register issues when skipping entries at the config #1696

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 24, 2024

Problem

At the storage configuration, it's possible to specify a section describing a device (drive, partition, volume group, logical volume, etc.) with a search entry to indicate such a description corresponds to one or several previously existing device(s) that should be found in the system.

That search entry can contain ifNotFound: "skip" to indicate the description should be ignored if the corresponding devices are not found.

If that happens, a warning is added to the list of found issues with a message like "No device found for an optional drive/partition/whatever".

That warning looks overkill. Especially having into account the default value for ifNotFound is "error", which means profiles using "skip" really mean it.

Solution

Reduce the noise by not longer generating the issue for missing optional devices.

@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11514959566

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 71.491%

Totals Coverage Status
Change from base Build 11500434799: -0.01%
Covered Lines: 16927
Relevant Lines: 23677

💛 - Coveralls

@ancorgs ancorgs marked this pull request as ready for review October 24, 2024 14:48
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a suggestion.

Co-authored-by: José Iván López <[email protected]>
@ancorgs ancorgs merged commit d0e1ca2 into agama-project:master Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants