Storage: Do not register issues when skipping entries at the config #1696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At the storage configuration, it's possible to specify a section describing a device (drive, partition, volume group, logical volume, etc.) with a
search
entry to indicate such a description corresponds to one or several previously existing device(s) that should be found in the system.That
search
entry can containifNotFound: "skip"
to indicate the description should be ignored if the corresponding devices are not found.If that happens, a warning is added to the list of found issues with a message like "No device found for an optional drive/partition/whatever".
That warning looks overkill. Especially having into account the default value for
ifNotFound
is "error", which means profiles using "skip" really mean it.Solution
Reduce the noise by not longer generating the issue for missing optional devices.