feat(web): storage config model #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11781455992Details
💛 - Coveralls |
joseivanlopez
force-pushed
the
storage-show-config
branch
5 times, most recently
from
73ad8b3
to
7d8c781
Compare
joseivanlopez
force-pushed
the
storage-show-config
branch
2 times, most recently
from
e52283e
to
2734ec7
Compare
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
storage-show-config
branch
from
2734ec7
to
6d68744
Compare
joseivanlopez
force-pushed
the
storage-show-config
branch
from
6d68744
to
00e3b01
Compare
ancorgs
reviewed
Nov 11, 2024
ancorgs
reviewed
Nov 11, 2024
ancorgs
reviewed
Nov 11, 2024
ancorgs
reviewed
Nov 11, 2024
| private bytes(value: config.SizeValueWithCurrent): number | undefined { | ||
| if (checks.isSizeCurrent(value)) return; | ||
| // TODO: bytes from string. | ||
| if (checks.isSizeString(value)) return; |
There was a problem hiding this comment.
Is this omission recorded somewhere? Sounds like something we should implement very soon.
There was a problem hiding this comment.
Yes, there is a follow-up item in the trello card.
joseivanlopez
force-pushed
the
storage-show-config
branch
from
00e3b01
to
26f5fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI components should be agnostic to the structure and complexity of the storage config.
Add a Config model to deal with the storage config. The model generates objects (e.g.,
Drive,Partition, etc) from the config data. This makes easier for the UI components to read and modify the config data.