Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Avoid calling await while holding a lock #663

Closed
wants to merge 1 commit into from
Closed

[RFC] Avoid calling await while holding a lock #663

wants to merge 1 commit into from

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jul 13, 2023

Clippy reports that in our code we call await while holding a lock. There are two possible solutions:

This PR implements the first solution. I have decided to use an scope instead of calling drop because of rust-lang/rust-clippy#6446.

@imobachgs imobachgs changed the title Avoid calling await while holding a lock [RFC] Avoid calling await while holding a lock Jul 13, 2023
@coveralls
Copy link

Coverage Status

coverage: 72.371% (-0.01%) from 72.383% when pulling 63cbe36 on imobachgs:fix-await-holding-lock into 2e11beb on openSUSE:master.

@imobachgs
Copy link
Contributor Author

Finally went with #664.

@imobachgs imobachgs closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants