Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort languages in the language selector by the language code #833

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Sort languages in the language selector by the language code #833

merged 1 commit into from
Oct 31, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Oct 31, 2023

Problem

  • The order of the languages in the language selector was not guaranteed

Solution

  • Explicitly sort the language by the language code

Testing

  • Tested manually

@coveralls
Copy link

Coverage Status

coverage: 75.192%. remained the same when pulling 74ecdd9 on sort_languages into 655e957 on master.

@lslezak lslezak merged commit 93876aa into master Oct 31, 2023
10 checks passed
@lslezak lslezak deleted the sort_languages branch October 31, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @imobachgs