Fix colors of higher values being unable to be overwritten by colors of lower values in Bitmap4 mode. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colors of lower values can now overwrite colors of higher values.
|
Whoops! My bad! The bitmap modes are probably wrong because they're not at all used or tested by us. |
corwinkuiper
added a commit
that referenced
this pull request
Sep 28, 2023
Expands on #486 by updating example and updating changelog. - [x] Changelog updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colors of lower values can now overwrite colors of higher values.
Before, this didn't happen, so it was impossible to clear the screen.
credit to origamiscienceguy in the GBA Dev discord for the fix.