Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 210 #211

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix for issue 210 #211

merged 3 commits into from
Oct 30, 2023

Conversation

jespercockx
Copy link
Member

This fixes #210 by using the same way to track module parameters that should be dropped as Agda uses internally. It also removes support for functions inside record modules (as in the test case for #185) since these do not exist in Haskell in the first place.

@jespercockx
Copy link
Member Author

@viktorcsimma WDYT?

@viktorcsimma
Copy link
Contributor

It's exactly what I needed; thank you! I've tested it with my project and it works flawlessly.

I agree that if we have to choose between #210 and #185; #210 is more important. I used to depend on agda-stdlib where there sometimes are functions in record namespaces, but that's a quite rare use case.

@jespercockx jespercockx merged commit 9883f96 into agda:master Oct 30, 2023
6 checks passed
@jespercockx jespercockx deleted the Issue210 branch October 30, 2023 20:58
@jespercockx jespercockx added this to the 1.2 milestone Nov 27, 2023
@jespercockx jespercockx restored the Issue210 branch December 8, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom parameters of values in where clauses
2 participants